Remove the deprecated getViewCSS() compatibility bridge - #4211
Draft
vogella wants to merge 1 commit into
Draft
Conversation
Contributor
The bridge was added when computeStyle(Element, String) replaced the W3C cascade accessor, so that the PDE CSS spy kept working while it still called getViewCSS().getComputedStyle(...). The spy no longer calls it, so its last known caller is gone. The org.eclipse.e4.ui.css.core.engine package is not exported to any PDE bundle, so nothing in the SDK referenced the method at compile time; the spy reached it reflectively.
vogella
force-pushed
the
css-drop-viewcss-bridge
branch
from
July 28, 2026 14:25
db37642 to
1caadc8
Compare
vogella
marked this pull request as ready for review
July 28, 2026 14:25
Contributor
Author
|
Something for early next release. |
vogella
marked this pull request as draft
July 29, 2026 08:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the deprecated
getViewCSS()default method fromCSSEngine. It was added in #4122 as a bridge for the PDE CSS spy, which at the time still went through the W3C cascade accessor, and was always meant to be temporary.Nothing in this repository calls it: the
org.eclipse.e4.ui.css.core.enginepackage is not exported to any PDE bundle, so the spy reached it reflectively rather than at compile time.The current spy no longer needs it either.
CssEngineCompatinorg.eclipse.pde.spy.css(eclipse-pde#2396, merged) gates onhasMethod(CSSEngine.class, "computeStyle", Element.class, String.class)and takes thecomputeStylepath on any engine that has it, so thegetViewCSSbranch is already unreachable on a reworked platform. eclipse-pde#2399 deletes that reflection entirely, but this removal does not depend on it.Local verification:
org.eclipse.e4.ui.css.coreandorg.eclipse.e4.ui.css.swtbuild clean and both suites are green (128 css.core, 210 css.swt with 9 skipped).Kept as a draft for now so it can follow eclipse-pde#2399.
The whole CSS engine is internal API